[netfilter-cvslog] r7048 - trunk/ulog/ulogd/extensions

kaber at trash.net kaber at trash.net
Wed Sep 19 14:47:46 CEST 2007


Author: kaber at trash.net
Date: 2007-09-19 14:47:45 +0200 (Wed, 19 Sep 2007)
New Revision: 7048

Modified:
   trunk/ulog/ulogd/extensions/ulogd_BASE.c
Log:
[Patch] ulogd, fix snprintf return

The attached patch fixes the treatment of snprintf return.

Eric Leblond <eric at inl.fr>


Modified: trunk/ulog/ulogd/extensions/ulogd_BASE.c
===================================================================
--- trunk/ulog/ulogd/extensions/ulogd_BASE.c	2007-09-12 15:28:58 UTC (rev 7047)
+++ trunk/ulog/ulogd/extensions/ulogd_BASE.c	2007-09-19 12:47:45 UTC (rev 7048)
@@ -82,8 +82,12 @@
 		for (i = 0; i < pkt->mac_len; i++, p++) {
 			tmp = snprintf(ptr+len, siz-len, "%02x%s", 
 					*p, i==pkt->mac_len-1 ? "":":");
-			if (tmp > siz-len)
+			if (tmp < 0)
 				break;
+			if (tmp >= siz-len) {
+				buf[siz] = '\0';
+				break;
+			}
 			len += tmp;
 		}
 		ret[0].value.ptr = buf;




More information about the netfilter-cvslog mailing list