[netfilter-cvslog] r6871 - trunk/ulog/ulogd/extensions

pablo at netfilter.org pablo at netfilter.org
Sat Jun 9 22:19:12 CEST 2007


Author: pablo at netfilter.org
Date: 2007-06-09 22:19:12 +0200 (Sat, 09 Jun 2007)
New Revision: 6871

Modified:
   trunk/ulog/ulogd/extensions/ulogd_BASE.c
Log:
fix wrong snprintf return value checking: never returns -1


Modified: trunk/ulog/ulogd/extensions/ulogd_BASE.c
===================================================================
--- trunk/ulog/ulogd/extensions/ulogd_BASE.c	2007-06-09 19:24:07 UTC (rev 6870)
+++ trunk/ulog/ulogd/extensions/ulogd_BASE.c	2007-06-09 20:19:12 UTC (rev 6871)
@@ -82,7 +82,7 @@
 		for (i = 0; i < pkt->mac_len; i++, p++) {
 			tmp = snprintf(ptr+len, siz-len, "%02x%s", 
 					*p, i==pkt->mac_len-1 ? "":":");
-			if (tmp == -1)
+			if (tmp > siz-len)
 				break;
 			len += tmp;
 		}




More information about the netfilter-cvslog mailing list