[netfilter-cvslog] r6633 - trunk/iptables/extensions

kaber at netfilter.org kaber at netfilter.org
Mon Jul 3 20:21:06 CEST 2006


Author: kaber at netfilter.org
Date: 2006-07-03 20:20:59 +0200 (Mon, 03 Jul 2006)
New Revision: 6633

Modified:
   trunk/iptables/extensions/libipt_dscp_helper.c
   trunk/iptables/extensions/libipt_sctp.c
Log:
[PATCH] iptables trivial compile warning cleanup (Phil Oester <kernel at linuxace.com>)

Cleanup a few compile warnings in latest snapshot:

extensions/libipt_dscp_helper.c:69: warning: 'dscp_to_name' defined but not used
extensions/libipt_sctp.c: In function 'print_chunks':
extensions/libipt_sctp.c:465: warning: value computed is not used
extensions/libipt_sctp.c:477: warning: value computed is not used

Resolves bug #457.


Modified: trunk/iptables/extensions/libipt_dscp_helper.c
===================================================================
--- trunk/iptables/extensions/libipt_dscp_helper.c	2006-06-26 13:10:39 UTC (rev 6632)
+++ trunk/iptables/extensions/libipt_dscp_helper.c	2006-07-03 18:20:59 UTC (rev 6633)
@@ -63,7 +63,7 @@
 }
 
 
-
+#if 0
 static const char *
 dscp_to_name(unsigned int dscp)
 {
@@ -78,5 +78,5 @@
 	exit_error(PARAMETER_PROBLEM,
 			"Invalid DSCP value `%d'\n", dscp);
 }
+#endif
 
-

Modified: trunk/iptables/extensions/libipt_sctp.c
===================================================================
--- trunk/iptables/extensions/libipt_sctp.c	2006-06-26 13:10:39 UTC (rev 6632)
+++ trunk/iptables/extensions/libipt_sctp.c	2006-07-03 18:20:59 UTC (rev 6633)
@@ -462,7 +462,8 @@
 	flag = 0;
 	for (i = 0; i < 256; i++) {
 		if (SCTP_CHUNKMAP_IS_SET(chunkmap, i)) {
-			flag && printf(",");
+			if (flag)
+				printf(",");
 			flag = 1;
 			print_chunk(i, numeric);
 			for (j = 0; j < flag_count; j++) {
@@ -474,7 +475,8 @@
 		}
 	}
 
-	flag && printf(" ");
+	if (flag)
+		printf(" ");
 out:
 	return;
 }




More information about the netfilter-cvslog mailing list