[netfilter-cvslog] r3682 - trunk/patch-o-matic-ng/connlimit/linux-2.6/net/ipv4/netfilter

laforge at netfilter.org laforge at netfilter.org
Sun Feb 13 19:15:41 CET 2005


Author: laforge at netfilter.org
Date: 2005-02-13 19:15:41 +0100 (Sun, 13 Feb 2005)
New Revision: 3682

Modified:
   trunk/patch-o-matic-ng/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c
Log:
Fix missing spin_unlock in error handling path (Closes: #299)


Modified: trunk/patch-o-matic-ng/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c
===================================================================
--- trunk/patch-o-matic-ng/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c	2005-02-13 18:13:44 UTC (rev 3681)
+++ trunk/patch-o-matic-ng/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c	2005-02-13 18:15:41 UTC (rev 3682)
@@ -115,8 +115,10 @@
 		       NIPQUAD(tuple.dst.ip), ntohs(tuple.dst.u.tcp.port));
 #endif
 		conn = kmalloc(sizeof(*conn),GFP_ATOMIC);
-		if (NULL == conn)
+		if (NULL == conn) {
+			spin_unlock(&data->lock);
 			return -1;
+		}
 		memset(conn,0,sizeof(*conn));
 		INIT_LIST_HEAD(&conn->list);
 		conn->tuple = tuple;




More information about the netfilter-cvslog mailing list