[netfilter-cvslog] r3652 - trunk/iptables/libiptc

[gandalf at netfilter.org]

Author: gandalf at netfilter.org
Date: 2005-02-04 08:38:02 +0100 (Fri, 04 Feb 2005)
New Revision: 3652

Modified:
   trunk/iptables/libiptc/libiptc.c
Log:
Revert the recent addition of memset()'s to TC_COMMIT. One of them is bogus and the other one needs more investigation to why valgrind is complaining.

Noticed and reverted by Phil Oester.


Modified: trunk/iptables/libiptc/libiptc.c
===================================================================
--- trunk/iptables/libiptc/libiptc.c	2005-02-02 19:20:15 UTC (rev 3651)
+++ trunk/iptables/libiptc/libiptc.c	2005-02-04 07:38:02 UTC (rev 3652)
@@ -2047,7 +2047,6 @@
 
 	counterlen = sizeof(STRUCT_COUNTERS_INFO)
 			+ sizeof(STRUCT_COUNTERS) * new_number;
-	memset(repl, 0, sizeof(*repl) + (*handle)->entries->size);
 
 	/* These are the old counters we will get from kernel */
 	repl->counters = malloc(sizeof(STRUCT_COUNTERS)
@@ -2057,8 +2056,6 @@
 		errno = ENOMEM;
 		return 0;
 	}
-	memset(repl->counters, 0, sizeof(STRUCT_COUNTERS)
-			* (*handle)->info.num_entries);
 	/* These are the counters we're going to put back, later. */
 	newcounters = malloc(counterlen);
 	if (!newcounters) {