<html>
<head>
<base href="https://bugzilla.netfilter.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Allow limit to use any value for time unit"
href="https://bugzilla.netfilter.org/show_bug.cgi?id=1214#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Allow limit to use any value for time unit"
href="https://bugzilla.netfilter.org/show_bug.cgi?id=1214">bug 1214</a>
from <span class="vcard"><a class="email" href="mailto:pablo@netfilter.org" title="Pablo Neira Ayuso <pablo@netfilter.org>"> <span class="fn">Pablo Neira Ayuso</span></a>
</span></b>
<pre>(In reply to Pablo Neira Ayuso from <a href="show_bug.cgi?id=1214#c7">comment #7</a>)
<span class="quote">> (In reply to Pablo Neira Ayuso from <a href="show_bug.cgi?id=1214#c6">comment #6</a>)
> > (In reply to Cyril from <a href="show_bug.cgi?id=1214#c5">comment #5</a>)
> > > Created <span class=""><a href="attachment.cgi?id=519" name="attach_519" title="Fixed patch with correct listing when calling nft list">attachment 519</a> <a href="attachment.cgi?id=519&action=edit" title="Fixed patch with correct listing when calling nft list">[details]</a></span>
> > > Fixed patch with correct listing when calling nft list
> > >
> > > This should solve this bug.
> >
> > Thanks Cyril.
> >
> > A couple of comments:
> >
> > static char buffer[20];
> >
> > Can we replace 20 by something more meaningful?
> >
> > strlen("18446744073709551616");
>
> Or add a comment
>
> /* maximum string length for 64-bit value. */
> static char buffer[20];
>
> So we remember about the 20 char magic number, this actually needs to be 21
> since we need to store \0.
>
> BTW, would you also add tests to nftables/tests/py/any/limit.t
>
> You will also need to update tests/py/any/limit.t.payload to include what
> nft --debug=netlink generates.
>
> Thanks !</span >
Regarding syntax, I wonder if it is worth to express this including time unit,
ie.
| NUM SECONDS
So we leave room to support things like "1 packet every 3 weeks" later on.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are watching all bug changes.</li>
</ul>
</body>
</html>