<html>
<head>
<base href="https://bugzilla.netfilter.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - xtables-eb.c:533: bad test ?"
href="https://bugzilla.netfilter.org/show_bug.cgi?id=1149">1149</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>xtables-eb.c:533: bad test ?
</td>
</tr>
<tr>
<th>Product</th>
<td>netfilter/iptables
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>x86_64
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P5
</td>
</tr>
<tr>
<th>Component</th>
<td>ip_tables (kernel)
</td>
</tr>
<tr>
<th>Assignee</th>
<td>netfilter-buglog@lists.netfilter.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>dcb314@hotmail.com
</td>
</tr></table>
<p>
<div>
<pre>xtables-eb.c:533:65: warning: logical 'and' of mutually exclusive tests is
always false [-Wlogical-op]
Source code is
if (optind + 1 >= argc || (argv[optind][0] == '-' && (argv[optind][1] < '0'
|| argv[optind][1] > '9')) ||
(argv[optind + 1][0] == '-' && (argv[optind + 1][1] < '0' &&
argv[optind + 1][1] > '9')))
Maybe better code
if (optind + 1 >= argc
|| (argv[optind][0] == '-'
&& (argv[optind][1] < '0' || argv[optind][1] > '9'))
|| (argv[optind + 1][0] == '-'
&& (argv[optind + 1][1] < '0' || argv[optind + 1][1] > '9')))</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are watching all bug changes.</li>
</ul>
</body>
</html>