<html>
    <head>
      <base href="https://bugzilla.netfilter.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - extensions: libxt_hashlimit: fix print_rate."
   href="https://bugzilla.netfilter.org/show_bug.cgi?id=1111">1111</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>extensions: libxt_hashlimit: fix print_rate.
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>netfilter/iptables
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>i386
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>major
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P5
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>unknown
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>netfilter-buglog@lists.netfilter.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>prahal@yahoo.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=490" name="attach_490" title="use uint64 modifier to print rate">attachment 490</a> <a href="attachment.cgi?id=490&action=edit" title="use uint64 modifier to print rate">[details]</a></span>
use uint64 modifier to print rate

This fixes iptables outputs 10/(null) instead of 10/sec as upto limit.
xt_hashlimit is already tagged C99.

A side effect is to get back openvpnas hooks when hashlimit upto is used.

This was tested (both breakage and fix) with iptables 1.6.0+snapshot20161117
from debian sid and testing.


NB: there are other similar printf placeholders that would benefit from the
same fix in libxt_hashlimit, but they are less critical (error reporting).
I am also uneasy with print_rate period parameter as uint32, I believe it
should have switched to uint64 with revision 2 of hashlimit.
There is also the cost_to_bytes and bytes_to_cost which I am unable to decide
whether the max divider and multiplier  should cope with uint64 and not stay
hardcoded to uint32.


All in all this patch fixes the only critical bug I experience with rev2 of
hashlimit but the above points might deserves bugs of their own.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are watching all bug changes.</li>
      </ul>
    </body>
</html>